Release: v1.10 - Copper Camel #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove default value from template schema for --reads
Also update caching for fetch_wf_config() so that it works purely on filenames / file hashes.
Fix bug with parsing params from main.nf
Schema launch updates
Moved code into nf_core.utils as reusable functions, so that they can be used for other stuff aside from nf-core schema build Also means some reduction in code duplication
* Use pre-release version of PyInquirer - capture keyboard interruptions, set defaults for lists * Make booleans use a True / False select list instead of confirm prompt * Various tweaks and changes / updates to make launch work with new web launch GUI
* Fix for schema website response type * Fix for launch web filtering for booleans
nf-core Launch web GUI
Realised that without this, the body content is not actually displayed on viewing by a user (and was typically being replaced by the HTML attachment in fancy email browsers).
New-new schema
New new schema
This is because the Python library dumps JSON with 4-space padding. So if the template has 2-space, if we make even the tiniest change the the diff replaces the whole schema with whitespace changes.
Schema build bug
Don't hard fail
Schema lint - warn about invalid title + description
Add Dockstore config file to template
Revert extra whitespace for schema web builder prompt
People can read about these on nf-core/configs I think, as that's where the config profile is kept.
…ow_schema.json Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Strip params docs
Bump to v1.10 - Copper Camel
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
===========================================
+ Coverage 64.91% 82.04% +17.13%
===========================================
Files 12 13 +1
Lines 1770 2746 +976
===========================================
+ Hits 1149 2253 +1104
+ Misses 621 493 -128
Continue to review full report at Codecov.
|
drpatelh
approved these changes
Jul 30, 2020
Hopefully - but I'm assuming that you will be carefully inspecting the entire diff, line by line as part of your review?! |
apeltzer
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devtomasterfor the v1.10 - Copper Camel release ✨