Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds a short sha representation to modules list command pointing to the repo specific commit #2870

Merged
merged 9 commits into from
Mar 18, 2024

Conversation

swampie
Copy link
Contributor

@swampie swampie commented Mar 18, 2024

Fixes #1763

Reduce the sha representation on modules list command by taking the first 7 chars and adds the link to the specific commit.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.96%. Comparing base (03646eb) to head (54afd8d).
Report is 2 commits behind head on dev.

Files Patch % Lines
nf_core/components/lint/__init__.py 77.77% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swampie
Copy link
Contributor Author

swampie commented Mar 18, 2024

For the reviewers: I added two links in the table
one for the repo_url and the other for the specific commit sha.

I also checked other commands but I only found the list one to expose the sha to the user. @ewels

@ewels

This comment was marked as resolved.

@ewels
Copy link
Member

ewels commented Mar 18, 2024

Nice one, thanks @swampie!

I was thinking that the git sha was in the output of nf-core modules lint, but you're right - I can't see it there.

Would be nice to add hyperlinks to Module name (to the nf-core modules page) and File path (to open the local file in a code editor), but thats' beyond the scope of my old issue 🙄

CHANGELOG.md Outdated Show resolved Hide resolved
@ewels ewels marked this pull request as ready for review March 18, 2024 21:52
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thank you!

@ewels ewels merged commit 4823fe4 into dev Mar 18, 2024
35 checks passed
@ewels ewels deleted the task_1763/short_sha branch March 18, 2024 22:22
@swampie swampie linked an issue Mar 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use short git sha in modules output
3 participants