Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use short git sha in modules output #1763

Closed
ewels opened this issue Aug 23, 2022 · 1 comment · Fixed by #2870
Closed

Use short git sha in modules output #1763

ewels opened this issue Aug 23, 2022 · 1 comment · Fixed by #2870
Assignees
@swampie
Labels
enhancement good-first-issue infrastructure modules Related to tools for working with DSL2 modules

Comments

@ewels
Copy link
Member

ewels commented Aug 23, 2022

Description of feature

Some of the modules commands print the entire git sha to the terminal, which is pretty long. It would be nicer to use just a six character sha instead to make better use of the available screen space.

Whilst we're there, we could also use more rich hyperlinks ([link=...]) to point directly to the sources.
@ewels ewels added enhancement modules Related to tools for working with DSL2 modules labels Aug 23, 2022
@mirpedrol mirpedrol modified the milestones: 2.5, 2.6 Aug 24, 2022
@mirpedrol mirpedrol modified the milestones: 2.6, 2.7 Oct 4, 2022
@ewels ewels removed this from the 2.7 milestone Nov 3, 2022
@github-project-automation github-project-automation bot moved this to Todo (Hackathon General) in nf-core Hackathon March 2023 Mar 21, 2023
@swampie swampie mentioned this issue Mar 18, 2024
Merged
4 tasks
@swampie swampie linked a pull request Mar 19, 2024 that will close this issue
fix: adds a short sha representation to modules list command pointing to the repo specific commit #2870
Merged
4 tasks
@swampie
Copy link
Contributor

swampie commented Mar 19, 2024

Closed by #2870

@swampie swampie closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swampie swampie

Labels
enhancement good-first-issue infrastructure modules Related to tools for working with DSL2 modules
Projects
No open projects
Hackathon: November 2023
Status: No status
Milestone
No milestone
3 participants
@ewels @swampie @mirpedrol