Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require minimum supported Python version for installation #2075

Merged
merged 3 commits into from
Nov 30, 2022
Merged

require minimum supported Python version for installation #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8afcaa3
require minimum supported Python version
fabianegli Nov 30, 2022
6154569
Update CHANGELOG.md
fabianegli Nov 30, 2022
2f9ca42
make black happy
fabianegli Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
- Don't print source file + line number on logging messages (except when verbose) ([#2015](https://github.com/nf-core/tools/pull/2015))
- Extended the chat notifications to Slack ([#1829](https://github.com/nf-core/tools/pull/1829))
- Allow other remote URLs not starting with `http` ([#2061](https://github.com/nf-core/tools/pull/2061))
- Prevent installation with unsupported Python versions ([#2075](https://github.com/nf-core/tools/pull/2075))

### Modules

Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"console_scripts": ["nf-core=nf_core.__main__:run_nf_core"],
"refgenie.hooks.post_update": ["nf-core-refgenie=nf_core.refgenie:update_config"],
},
python_requires=">=3.7, <4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 4, is that a thing?? 😰 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I guess we would want to make sure it works before supporting it 😅

install_requires=required,
packages=find_packages(exclude=("docs")),
include_package_data=True,
Expand Down