require minimum supported Python version for installation #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
fabianegli
commented
Nov 30, 2022
mashehu
approved these changes
Nov 30, 2022
fabianegli
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #2075 +/- ##
==========================================
+ Coverage 67.76% 67.79% +0.03%
==========================================
Files 43 43
Lines 5559 5559
==========================================
+ Hits 3767 3769 +2
+ Misses 1792 1790 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ewels
reviewed
Nov 30, 2022
| @@ -35,6 +35,7 @@ | |||
| "console_scripts": ["nf-core=nf_core.__main__:run_nf_core"], | |||
| "refgenie.hooks.post_update": ["nf-core-refgenie=nf_core.refgenie:update_config"], | |||
| }, | |||
| python_requires=">=3.7, <4", | |||
There was a problem hiding this comment.
But I guess we would want to make sure it works before supporting it 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is hitherto possible to install nf-core tools with pip and unsupported older Python versions. This PR prevents that.
Closes #1876
PR checklist
CHANGELOG.mdis updateddocsis updated