Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom name #1822

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Custom name #1822

merged 7 commits into from
Oct 20, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Sep 8, 2022

Check that the workflow name provided with a template doesn't contain dashes. Close #1806

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1822 (0004b9b) into dev (b6be4ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1822   +/-   ##
=======================================
  Coverage   61.10%   61.10%           
=======================================
  Files          37       37           
  Lines        4677     4677           
=======================================
  Hits         2858     2858           
  Misses       1819     1819           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol marked this pull request as ready for review September 8, 2022 14:23
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if Name is not too ambiguous in the prompt. Maybe we should switch to pipeline name? @ewels any opinion?

nf_core/create.py Show resolved Hide resolved
@ewels
Copy link
Member

ewels commented Sep 20, 2022

Reasoning is here: #1805

I agree that Name is too vague though. I'd prefer to go the other way with --workflow-name I think (or ignore the issue and do nothing).

@ewels

This comment was marked as resolved.

@mashehu

This comment was marked as resolved.

nf_core/create.py Outdated Show resolved Hide resolved
@mirpedrol mirpedrol requested a review from mashehu October 20, 2022 09:05
@mirpedrol mirpedrol merged commit 6cd9134 into nf-core:dev Oct 20, 2022
@mirpedrol mirpedrol deleted the custom-name branch October 20, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants