Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.1 merge Master > Dev #140

Merged
merged 117 commits into from
Aug 14, 2018
Merged

Version 1.1 merge Master > Dev #140

merged 117 commits into from
Aug 14, 2018

Conversation

ewels
Copy link
Member

@ewels ewels commented Aug 14, 2018

Preparing a v1.1 release

Just needs a version number bump and changelog update

sven1103 and others added 30 commits July 17, 2018 17:03
PyPi cannot work with the requirements.txt, as it is not
published with the nf-core tools distribution.
The better way is to define the required modules
in the respective section in the setuptools setup()
method.
fix CI with new MultiQC version in minimal example
Made a basic command which runs cookiecutter on the template files.
Removed large number of cookiecutter variables, made init command use flags only.
This script should be executed, once a new release is done
for nf-core tools. It will traverse all pipelines and make
changes according to the cookiecutter template and commit
them into each pipelines branch 'TEMPLATE'.
* Added new command line option to specify version for new pipeline
* Split functionality out into its own file
* Wrote feature to initialise a git repository and make a commit in new pipeline
Instead call the command nf-core create
Updated with recent cookiecutter updates
@ewels ewels added the WIP Work in progress label Aug 14, 2018
@ewels ewels requested a review from a team August 14, 2018 16:08
@ewels ewels removed the WIP Work in progress label Aug 14, 2018
ewels and others added 3 commits August 14, 2018 18:14
v1.1 version bump & changelog update
Use config.get to avoid KeyErrors. Don't use --release for nf-core/tools
@codecov-io
Copy link

Codecov Report

Merging #140 into master will decrease coverage by 6.4%.
The diff coverage is 48.97%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #140      +/-   ##
=========================================
- Coverage   95.31%   88.9%   -6.41%     
=========================================
  Files           6       7       +1     
  Lines         661     730      +69     
=========================================
+ Hits          630     649      +19     
- Misses         31      81      +50
Impacted Files Coverage Δ
nf_core/create.py 0% <0%> (ø)
nf_core/release.py 100% <100%> (ø) ⬆️
nf_core/lint.py 96.85% <93.02%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf80242...cb2bc27. Read the comment docs.

Copy link
Member

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!

@sven1103 sven1103 merged commit 8e675af into master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants