-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules refactoring #1171
Modules refactoring #1171
Conversation
…cture Adapt `modules install` to new directory structure
Adjust `modules lint` to new directory structure
…into modules-refactoring
Updated `modules remove` and `modules list` for restructuring
…into modules-restructuring
Modules restructuring
Codecov Report
@@ Coverage Diff @@
## dev #1171 +/- ##
==========================================
- Coverage 71.56% 70.68% -0.88%
==========================================
Files 29 48 +19
Lines 3355 5107 +1752
==========================================
+ Hits 2401 3610 +1209
- Misses 954 1497 +543
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay looks good from my side, just two changes for the code I added
Python linting (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general to me!
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
Nice, thanks! Now all we need to is to make black happy and then we can merge this beast 😅 |
This PR combines all of the changes that were necessary to adapt the code to the new structure of
nf-core/modules
and nf-core pipelines.PR checklist
CHANGELOG.md
is updateddocs
is updated