Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt modules install to new directory structure #1168

Conversation

ErikDanielsson
Copy link
Contributor

Updated nf-core modules install (and some other stuff...) to accommodate new directory structure, as suggested in #1159:

  • Update structure in modules.json to:
...
repos: {
    "repo_owner/repo_name": {
         "module_name": {
              "git_sha": commit_sha
         }
    ...
    } 
    ...
}
  • Updated creation of modules.json accordingly.
  • Changed default value for since in module_utils.get_module_git_log due to breaking changes in nf-core/modules.
  • Changed references to software directory to modules in ModulesRepo.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ErikDanielsson ErikDanielsson changed the title Modules install new structure Adapted modules install to new directory structure Jul 7, 2021
@ErikDanielsson ErikDanielsson changed the title Adapted modules install to new directory structure Adapt modules install to new directory structure Jul 7, 2021
@KevinMenden
Copy link
Contributor

PR looks good, but we'll need to add a few things to get the tests running. I think we can merge once we have the tests for modules install running, and then we can fix the other tests in separate PRs I guess.

You'll need to modify the pipeline template --> simply rename the software into the modules directory for instance. I'll try to think of other changes but maybe you already fixed it now 😅

@ErikDanielsson ErikDanielsson changed the base branch from dev to modules-refactoring July 7, 2021 13:54
@ErikDanielsson ErikDanielsson merged commit 2751848 into nf-core:modules-refactoring Jul 7, 2021
@ErikDanielsson ErikDanielsson deleted the modules-install-new-structure branch July 26, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants