Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualimap to pipeline #205

Merged

Conversation

lpantano
Copy link
Contributor

@lpantano lpantano commented May 6, 2019

Added qualimap to the main pipeline, with option to skip it, labeled as low-memory step. Updated the docs and readme mentioning the tools.

Related issue: #202

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

README.md Outdated Show resolved Hide resolved
main.nf Show resolved Hide resolved
@lpantano
Copy link
Contributor Author

lpantano commented May 7, 2019

I forgot to add the qualimap version, and I realized that it doesn't have a way to do it without output with an error. get_software_versions will break if a tool exit with error?

@apeltzer
Copy link
Member

apeltzer commented May 8, 2019

Typically, you just add each tool that is in the pipeline to the get_software_versions process for the sake of completeness yes :-)

You can redirect the output of qualimap to a file in that process, e.g. also redirecting stderr to the same file which you can then parse in the scrape_software_versions.py script in /bin/. Redirecting can be done like this:

https://www.brianstorti.com/understanding-shell-script-idiom-redirect/

@lpantano
Copy link
Contributor Author

lpantano commented May 8, 2019

Thanks. The || 1 made the trick to avoid the error in the process. But now the file is not parsed, for some reason is not in the final software_versions.csv, where is scrape_software_versions.py code?

@apeltzer
Copy link
Member

apeltzer commented May 8, 2019

Always in bin of the pipeline !

@lpantano
Copy link
Contributor Author

lpantano commented May 8, 2019

ok! that was helpful. Now is part of the version file.

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now 👍 Thanks a bunch!

@apeltzer apeltzer merged commit e0cfa02 into nf-core:dev May 9, 2019
@lpantano lpantano deleted the lpantano-qualimap-pipeline branch May 9, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants