-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add qualimap #202
Comments
Sure, why not ? |
I feel quite stupid, but I tried to add it (and I have done successful pipelines before with nf) but for some reason, it is only doing qualimap for one sample, maybe somebody can help me? I added the code here: https://github.com/lpantano/rnaseq/blob/dev/main.nf#L896 like the output says:
|
Probably used a queue channel for e.g. the reference data |
lol, ok, got it. |
Yep.
Should fix it. |
thanks. That was fun!
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ok, all is working and I am going through the list to make the pull request, but I have a couple of questions:
Thanks! |
Ideally, a.) should resolve itself once we updated the That way, the tests will find qualimap properly to test everything when you do your "real" PR ;-) Since adding just some recipes shouldn't break things, I think its fine to do a separate PR that just includes the |
Oh! that is smart :) I’ll do that PR first!
|
related issue: nf-core#202
It would be redundant with rseqc maybe but I think is much faster for some cases and we can give the option to use one or another.
Is ok if I work on adding qualimap for QC?
The text was updated successfully, but these errors were encountered: