-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.4 #121
base: master
Are you sure you want to change the base?
Release 1.4 #121
Conversation
Important! Template update for nf-core/tools v3.0.2
Add graph refinement options for pixelator 0.19
Fix validation issues after nf-core/tools v3 template update
…overed Remove `--save_recovered_components` options for graph outputs
Update containers for 0.19.0
Bump version for 1.4 release
Important! Template update for nf-core/tools v3.1.0
Update metromap, bump conda versions
Add `process_long` labels to AMPLICON and COLLAPSE
|
Can you give us a hand on this one @mashehu and @avani-bhojwani on a short timeline? Thanks! |
consider updating to version 2.0.0, rather than 1.4.0 since the deprecation of a parameter could justify a major release (https://nf-co.re/docs/guidelines/pipelines/requirements/semantic_versioning#major-release-eg-143-to-200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - Just a few questions/changes
} | ||
summary { | ||
beforeText = validation.help.beforeText | ||
afterText = validation.help.afterText | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} | |
// Load modules.config for DSL2 module specific options | |
includeConfig 'conf/modules.config' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this slack message : https://nfcore.slack.com/archives/C04QR0T3G3H/p1734098510601899
|
||
includeConfig 'modules.config' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may not be needed if we have it in the nextflow.config file instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this file be deleted if it is not used?
Release 1.4
[1.4.0] - 2024-12-13
Enhancements & fixes
--save_recovered_components
options for graph outputs