-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.4 #121
base: master
Are you sure you want to change the base?
Release 1.4 #121
Conversation
Important! Template update for nf-core/tools v3.0.2
Add graph refinement options for pixelator 0.19
Fix validation issues after nf-core/tools v3 template update
…overed Remove `--save_recovered_components` options for graph outputs
Update containers for 0.19.0
Bump version for 1.4 release
Important! Template update for nf-core/tools v3.1.0
Update metromap, bump conda versions
Add `process_long` labels to AMPLICON and COLLAPSE
|
Can you give us a hand on this one @mashehu and @avani-bhojwani on a short timeline? Thanks! |
consider updating to version 2.0.0, rather than 1.4.0 since the deprecation of a parameter could justify a major release (https://nf-co.re/docs/guidelines/pipelines/requirements/semantic_versioning#major-release-eg-143-to-200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - Just a few questions/changes
Since the push to follow semantic versioning more strictly is only from last month, we would like to do this still as a minor release. We will have a v2 following quite soon and can start strict semantic versioning with that version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments about local modules. Would also be great if they are unit tested with nf-tests. is this something you can work on adding before release ?
@@ -3,6 +3,51 @@ | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
## [[1.4.0](https://github.com/nf-core/pixelator/releases/tag/1.4.0)] - 2024-12-13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update date before release
@@ -12,6 +12,7 @@ of [`pixelator`](https://github.com/PixelgenTechnologies/pixelator). | |||
|
|||
The pipeline consists of the following steps: | |||
|
|||
- [Pipeline information](#pipeline-information) - Report metrics generated during the workflow execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
best to list these steps in the order of execution
(see `--multiplet_recovery`). These new component IDs are then stored in the "component" column. The information to keep track of the original and | ||
newly recovered components are stored in a file (components_recovered.csv). | ||
This file is not included in the output folder by default, but can be included by passing `--save_recovered_components`. | ||
(see `--multiplet_recovery`). These new component IDs are then stored in the "component" column. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stored in column where ?
|
||
process PIXELATOR_COLLECT_METADATA { | ||
label 'process_single' | ||
cache false | ||
|
||
conda "bioconda::pixelator=0.18.2" | ||
conda "bioconda::pixelator=0.19.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
best to follow the standard practice of putting the package info in an environment.yml
and provide that
@@ -70,8 +65,7 @@ process PIXELATOR_COLLECT_METADATA { | |||
parameters: params | |||
] | |||
|
|||
def nextflowJson = JsonOutput.toJson(metadata) | |||
|
|||
def nextflowJson = groovy.json.JsonOutput.toJson(metadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to collect version info from this module
contributors = [ | ||
// TODO nf-core: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0 | ||
[ | ||
name: 'Pixelgen Technologies AB', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update contributor info
doi = '10.1101/2023.06.05.543770' | ||
} | ||
|
||
// Load modules.config for DSL2 module specific options | ||
includeConfig 'conf/modules.config' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need modules.config ?
Release 1.4
[1.4.0] - 2024-12-13
Enhancements & fixes
--save_recovered_components
options for graph outputs