Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test data paths batch 9 #6066

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Jul 31, 2024

PR checklist

Closes #XXX

  • Updated test data paths batch 9
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@GallVp
Copy link
Member Author

GallVp commented Jul 31, 2024

This issue with nf-test (modules/nf-core/centrifuge/centrifuge, docker_self_hosted) might be solved by using chmod. A similar issue was seen in the past with fastk.

find . -name '*.ktab*' \\

I think this is unique to docker_self_hosted due to absence of -u $(id -u):$(id -g) which is because of its own reasons. Any input on this one @mirpedrol ?

docker.runOptions = '-u $(id -u):$(id -g) --platform=linux/amd64'
}
docker_self_hosted {
docker.enabled = true
docker.fixOwnership = true
docker.runOptions = '--platform=linux/amd64'

@GallVp
Copy link
Member Author

GallVp commented Aug 1, 2024

I'll try to fix the untar in a separate PR.

@GallVp
Copy link
Member Author

GallVp commented Aug 1, 2024

It is related to #5970

@GallVp
Copy link
Member Author

GallVp commented Aug 1, 2024

Leaving the centrifuge out for now.

@SPPearce SPPearce added this pull request to the merge queue Aug 1, 2024
Merged via the queue into nf-core:master with commit 0a0b723 Aug 1, 2024
40 checks passed
@GallVp GallVp deleted the testpaths/batch9 branch August 2, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants