Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible trimming of bams based on library type #523

Merged
merged 16 commits into from
Jul 23, 2020
Merged

Flexible trimming of bams based on library type #523

merged 16 commits into from
Jul 23, 2020

Conversation

TCLamnidis
Copy link
Collaborator

@TCLamnidis TCLamnidis commented Jul 21, 2020

Description:

  1. Fixed a bug where evaluation of boolean options was interpreted as string, which caused these options to always be on (e.g. trimbam softclipping). @jfy133
  2. Replaced left and right trimming parameters with library specific left and right parameters. It is now possible to trim hUDG libraries e.g. 2bp on each side and nonUDG libraries e.g. 7bp on each side within the same eager run. Should provide more robust genotyping and easier way to exclude damage without throwing away data.
  3. Added def before definitions of variables including ifelse clauses, for clearer definitions.
  4. Renamed pmdtools test in CI. WAs erroneously tagged TRIMBAM. Now it is PMDTOOLS.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (nextflow run . -profile test,docker --paired_end).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@TCLamnidis TCLamnidis requested a review from jfy133 July 21, 2020 14:28
@TCLamnidis TCLamnidis linked an issue Jul 21, 2020 that may be closed by this pull request
Merge trim-bam-fix into flxitrim
@jfy133 jfy133 merged commit f06df88 into dev Jul 23, 2020
@apeltzer apeltzer deleted the flexitrim branch July 28, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for differential trimming based on UDG treatment?
2 participants