Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for differential trimming based on UDG treatment? #512

Closed
TCLamnidis opened this issue Jul 15, 2020 · 1 comment · Fixed by #523
Closed

Allow for differential trimming based on UDG treatment? #512

TCLamnidis opened this issue Jul 15, 2020 · 1 comment · Fixed by #523
Assignees
Labels
enhancement New feature or request

Comments

@TCLamnidis
Copy link
Collaborator

We currently have a single trimming parameter for all libraries. This can become an issue if submitting half-UDG and non-UDG libraries together via TSV. The former need 2-3bp trimmed, but the latter can need 7-10 bp. So either you lose a bunch of data for no reason, or you retain damage in your data.

We could branch the input by UDG treatment/SS/DS and have separate parameters for the end user to specify how much to trim in which libraries.

Something like this
--bamutils_clip_left becomes --bamutils_clip_left_halfudg & --bamutils_clip_left_nonudg

Then the trimming process entails an if clause changing the specific parameters by library/udg type.

@jfy133 jfy133 added the enhancement New feature or request label Jul 16, 2020
@jfy133
Copy link
Member

jfy133 commented Jul 16, 2020

Maybe a good idea - I don't think this would need to be branching even, just a condition in the script block.

Simple pseudocode:
i.e. trim_amount = udg_treatment == 'half' ? params.clip_no_udg : params.clip_no_udg

Don't know what the difference with SS would be though?

Thoughts @nf-core/eager ?

@TCLamnidis TCLamnidis linked a pull request Jul 21, 2020 that will close this issue
7 tasks
@jfy133 jfy133 closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants