Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource requirement and abstraction process fixes #321

Merged
merged 13 commits into from
Dec 19, 2019
Merged

Resource requirement and abstraction process fixes #321

merged 13 commits into from
Dec 19, 2019

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Dec 19, 2019

This includes a range of bug fixes and enhancements

  1. Generalises default resource requirements rather than process specific settings with withLabel to address Generalise base.configs #310
  2. Fixes a bug reported by Marcel Keller that genotyping was only running for one sample. This was due to the reference FASTA being consumed. I also expanded to ensure all processes have independent FASTA input channels. (thanks to @drpatelh @mahesh-panchal for troubleshooting)
  3. Adds an ignore for pipe errors (exit code 141) for pmdtools as pmdtools still fails even if samtools says 'err no'
  4. Adds documentation for pipeline specific institutional profiles.
  5. Fixes an instability with using tee for samtools which was trying to paralellise within a paralellised process

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@jfy133 jfy133 requested a review from apeltzer December 19, 2019 10:03
@apeltzer apeltzer merged commit d8ccb82 into nf-core:dev Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants