Fairmat 2024: proposal on atom probe microscopy (APM) #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on feedback from @RubelMozumder, @lukaspie, as well as @sanbrock
Application definition for XPS
…or_circuits Cleaned the too many base classes for circuits and cleaned base classes for describing a computer
Make geometries and sourceTYPE recommended in NXxps
change docs in NXcollectioncolumn
…ses by definitions in appdefs
…NXms with NXmicrostructure to avoid confusing the symbol convention with mass spectrometry as the abbreviation NXms may suggest
…con and eventually make this NXmicrostructure
black code style
… contributed but implicitly as a dependency of NXem, NXem_ebsd, NXem_img proposed for voting and acceptance
black formatting isort dev_tools
lukaspie
force-pushed
the
fairmat-2024-apm
branch
3 times, most recently
from
690f2d2 to
0f7ac38
Compare
lukaspie
force-pushed
the
fairmat-2024-apm
branch
from
0f7ac38 to
8583dfd
Compare
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored version for NXapm including feedback from the atom probe microscopy/tomography community
Refactoring of NXimage, NXspectrum_set base classes and examples for their usage
More complete representation of instrument components
Examples for documenting method-specific results with some contextualization for processing APM data
This PR depends heavily on others that make changes to existing base classes or introduce base classes that are to be used outside of APM as well. Thus, it will be much smaller once the discussion on these PRs is done and this particular branch here has been rebased:
#1407
#1408
#1410
#1412
#1413
#1414
#1415
#1419
#1420
#1486
There are however several new base classes that are currently only used within NXapm that are introduced here:
For a full list of dependant changes, see #1466