-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAIRmat 2024: additional base classes in NXinstrument #1419
Open
lukaspie
wants to merge
25
commits into
nexusformat:main
Choose a base branch
from
FAIRmat-NFDI:fairmat-2024-nxinstrument
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FAIRmat 2024: additional base classes in NXinstrument #1419
lukaspie
wants to merge
25
commits into
nexusformat:main
from
FAIRmat-NFDI:fairmat-2024-nxinstrument
+465
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspie
changed the title
Fairmat 2024: additional base classes in NXinstrument
FAIRmat 2024: additional base classes in NXinstrument
Sep 23, 2024
lukaspie
force-pushed
the
fairmat-2024-nxinstrument
branch
from
September 23, 2024 16:53
64226dd
to
5f5b269
Compare
Open
Open
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
lukaspie
commented
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
woutdenolf
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
woutdenolf
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
phyy-nx
reviewed
Sep 30, 2024
lukaspie
commented
Sep 30, 2024
lukaspie
commented
Sep 30, 2024
move NXfabrication to base_classes pull out base classes cited in NXinstrument
Co-authored-by: Aaron S. Brewster <asbrewster@lbl.gov> Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
lukaspie
force-pushed
the
fairmat-2024-nxinstrument
branch
from
January 9, 2025 15:05
cd9fa25
to
254fc4a
Compare
@phyy-nx I also made one more change in that I changed the links in the |
mkuehbach
reviewed
Jan 15, 2025
mkuehbach
reviewed
Jan 15, 2025
lukaspie
force-pushed
the
fairmat-2024-nxinstrument
branch
from
January 16, 2025 08:03
2f4276e
to
e42023a
Compare
lukaspie
added a commit
to FAIRmat-NFDI/nexus_definitions
that referenced
this pull request
Jan 16, 2025
Ready for final review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds four unnamed base classes to
NXinstrument
.NXactuator
: see description/discussion in Fairmat 2024: actuators and sensors in NXenvironment #1414NXfabrication
: see description/discussion in Fairmat 2024: actuators and sensors in NXenvironment #1414NXhistory
: this is a new base class that is meant to describe the history of any physical object (in this case, the instrument history).NXhistory
is meant to contain many instances of the new base classNXactivity
, which describes any physical activity that was performed on the physical entity prior or during the experiment. Note this is intentionally different thanNXprocess
, which describes processing of the data.NXresolution
: This is meant to describe the resolution of a measureable physical quantity. Here, we are describing many different ways of a) how such a resolution can be described, and b) how such a resolution can be obtained. For b), we are also moving the base classNXcalibration
(a subclass ofNXprocess
) from contributed to base_classes and slightly expand its former definition .In addition,
NXnote
is expanded to contain more information about a given resource (like the URI of the resource, the checksum of a file, etc.).