-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Button): button link onClick warning #1427
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@camcam2605 is attempting to deploy a commit to the NextUI Team on Vercel. A member of the Team first needs to authorize it. |
The warning is justified regardless of element IMO. |
@jguddas we should ignore that warning if we don't use |
If we have a link we should be using |
Hey @camcam2605 thanks for contributing to NextUI. However, we should create our use-link hook to prevent this as we did with the button one https://github.com/nextui-org/nextui/blob/main/packages/hooks/use-aria-button/src/index.ts#L134-L136 I'll take this, thank you! |
Closes #1423
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information