Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): button link onClick warning #1427

Closed
wants to merge 2 commits into from

Conversation

camcam2605
Copy link
Contributor

Closes #1423

📝 Description

Add a brief description

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023

⚠️ No Changeset found

Latest commit: 60d4933

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 7:46am

@vercel
Copy link

vercel bot commented Aug 18, 2023

@camcam2605 is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

@jguddas
Copy link
Contributor

jguddas commented Aug 18, 2023

The warning is justified regardless of element IMO.

@camcam2605
Copy link
Contributor Author

@jguddas we should ignore that warning if we don't use onClick

@jguddas
Copy link
Contributor

jguddas commented Aug 18, 2023

@jguddas we should ignore that warning if we don't use onClick

If we have a link we should be using useLink not useButton.

@jrgarciadev
Copy link
Member

Hey @camcam2605 thanks for contributing to NextUI. However, we should create our use-link hook to prevent this as we did with the button one https://github.com/nextui-org/nextui/blob/main/packages/hooks/use-aria-button/src/index.ts#L134-L136

I'll take this, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Button as a Link (Polymorphic) throws deprecation warning
3 participants