[BUG] - Button as a Link (Polymorphic) throws deprecation warning

[phev8]

NextUI Version

v2.0.22

Describe the bug

When using a Button as a link (as showed in the documentation), I get a deprecation warning:

onClick is deprecated, please use onPress

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

export default function App() {
  return (
    <Button
      href="https://github.com/nextui-org/nextui"
      as={Link}
      color="primary"
      showAnchorIcon
      variant="solid"
    >
      Button Link
    </Button>
  );
}

Expected behavior

The button should behave as a link and navigate to the next page without depreciation warning.

Screenshots or Videos

No response

Operating System Version

macOS

Browser

Chrome

[jrgarciadev]

This warning is intentional, please use onPress instead of onClick.

here's why we use onPress:

https://react-spectrum.adobe.com/blog/building-a-button-part-1.html

[phev8]

I saw this, but I don't use onClick the Link component of NextUI does, doesn't it?
Or maybe just the documentation is misguiding in this place on how to implement a link that looks like a button?

[jrgarciadev]

Oh got it!, I'll reopen this then, thanks!

[phev8]

Thank you! Appreciate the great work
Also I just noted this issue, in case it would lead to issues in future, right now, it seems to work apart from the warning.

[camcam2605]

@jrgarciadev because onClick existed in the button props before it passed to the Link.