Annotate package installs #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
force-pushed
the
victorlin/annotate-package-installs
branch
from
4377527
to
aebb34a
Compare
victorlin
commented
Oct 13, 2022
tsibley
reviewed
Oct 13, 2022
Upon removing libpng-dev, the build error from VCFtools is:
No package 'zlib' found
libpng-dev also installs zlib1g-dev as a dependency, which is why that
worked. The build succeeds if zlib1g-dev is installed directly, so do
that to avoid unnecessary installs.
The build succeeds without this installed. It was likely used at some point since added in 3917c1b, but building from that commit no longer works due to changes in upstream URL availability. I did not dig deeper to find out exactly where it was used.
victorlin
force-pushed
the
victorlin/annotate-package-installs
branch
from
aebb34a
to
a9dd473
Compare
Currently, the reasoning on why each package is used 1. can be deduced from direct references in the Dockerfile (e.g. curl), or 2. can be deduced from git blame (e.g. jq: c256a30), or 3. is unclear. To make this easier, document why each package is installed.
victorlin
force-pushed
the
victorlin/annotate-package-installs
branch
from
a9dd473
to
10ecb42
Compare
tsibley
approved these changes
Oct 17, 2022
|
Great to have this documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Currently, the reasoning on why each package is used
To make this easier, document why each package is installed.
Related issue(s)
N/A
Testing