Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test whether re-installing GMP improves execution time of long-running workflows #97

Open
victorlin opened this issue Oct 17, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@victorlin
Copy link
Member

Context

GMP was removed from the final image in ce07dad. As @tsibley noted in #93 (comment):

Generally speaking, GMP is often required for bignum support in numerical software, so it's not surprising to see. (I'm a little surprised we don't need it at runtime, but static linking could explain this. Slightly terrifyingly, I've run into libraries that make their use of a bignum library like GMP optional, falling back to a horrifyingly slow implementation when GMP isn't available. Hopefully that's not the case here!)

Possible solution

  1. Open a PR to re-install GMP on the final image.
  2. Use the test image to run ncov and/or monkeypox workflows.
  3. If there is a substantial improvement in execution time, merge PR from (1).
@victorlin victorlin added the enhancement New feature or request label Oct 17, 2022
@tsibley
Copy link
Member

tsibley commented Oct 18, 2022

May be necessary to include it at build time in the builder image too.

@fanninpm
Copy link

I tried running augur tree --alignment whatever.fasta --method fasttree and got the following error:

FastTreeDblMP: error while loading shared libraries: libgomp.so.1: cannot open shared object file: No such file or directory

@victorlin
Copy link
Member Author

@fanninpm that sounds like a valid but unrelated bug. Could you open a new issue with that error message and include details on the Docker image being used (e.g. output of docker image ls --digests nextstrain/base)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

3 participants