Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a file to keep track of deprecated features #1371

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 20, 2023

Description of proposed changes

Descriptive text inspired by an analogous file used in the Commander.js repo.¹

¹ https://github.com/tj/commander.js/blob/f1ae2db8e2da01d6efcbfd59cbf82202f864b0c1/docs/deprecated.md

Related issue(s)

Checklist

  • Checks pass
  • If making user-facing changes, add a message in CHANGES.md summarizing the changes in this PR

@victorlin victorlin self-assigned this Dec 20, 2023
@victorlin victorlin requested a review from a team December 20, 2023 20:28
@victorlin
Copy link
Member Author

I just realized we have the Breaking Changes docs page, which overlaps with DEPRECATED.md. I'll merge the two together.

I created DEPRECATED without knowing that there was already a similar
page in the docs. That page was not very visible to developers, with no
mention in the dev docs.

Instead of continuing with the breaking changes file, move relevant
contents into DEPRECATED and automatically render DEPRECATED in the
docs.
This documents the process of adding to the new DEPRECATED.md file.
@victorlin victorlin merged commit 543c433 into master Dec 20, 2023
21 of 22 checks passed
@victorlin victorlin deleted the victorlin/deprecated-file branch December 20, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants