Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove export v1 #1266

Open
1 of 3 tasks
victorlin opened this issue Jul 26, 2023 · 4 comments
Open
1 of 3 tasks

Remove export v1 #1266

victorlin opened this issue Jul 26, 2023 · 4 comments

Comments

@victorlin
Copy link
Member

victorlin commented Jul 26, 2023

Prompted by #1262 (comment).

Description

export v2 (for Auspice v2) has been around for a while, and should be widely adopted at this point. There should no longer be a need to maintain export v1 in newer versions of Augur.

Tasks

@joverlee521
Copy link
Contributor

Noting that we still use export v1 for the private seasonal flu builds, which are visualized with a deprecated version of auspice.

@victorlin
Copy link
Member Author

@joverlee521 that's good to know. Do you expect that those builds would benefit from newer features of Augur? Or can it also vendor its own version of Augur, similar to its current usage of Auspice?

It doesn't seem sensible to keep export v1 around just for one project, but I also realize that it's a project of our own lab...

@joverlee521
Copy link
Contributor

Hmm, maybe we could vendor its own version of export v1 for that one rule only.
The rest of the workflow shares rules with the public flu builds which do benefit from newer features of Augur.

@jameshadfield
Copy link
Member

Let's at least add the deprecation warning. It's good practice to leave things around for a while after the warning appears, so that'll give us plenty of time to decide what to do re: seasonal flu. In hindsight, having a sub-(sub-?)command wasn't one of my best ideas so perhaps we could explore things like making augur export the canonical export function, which behaves as augur export v2 currently does, but also have a (hidden) augur export v1 command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants