Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code 2 if TreeTimeError encountered #1367

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

jameshadfield
Copy link
Member

@jameshadfield jameshadfield commented Dec 20, 2023

Current behaviour is to exit code 0 ("success") if augur encounters TreeTimeError. The initial implementation
(3256319) exited code 2 but this was removed by 403da88

This bug was first observed (by me, at least) as part of #1360

Current behaviour is to exit code 0 ("success") if augur encounters
`TreeTimeError`. The initial implementation
(3256319) exited code 2 but this was
removed by 403da88

This bug was first observed (by me, at least) as part of
#1360
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e346693) 66.14% compared to head (e98f088) 66.13%.

Files Patch % Lines
augur/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   66.14%   66.13%   -0.01%     
==========================================
  Files          68       68              
  Lines        7221     7222       +1     
  Branches     1777     1777              
==========================================
  Hits         4776     4776              
- Misses       2176     2177       +1     
  Partials      269      269              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jameshadfield jameshadfield merged commit 52a0366 into master Dec 20, 2023
23 of 24 checks passed
@jameshadfield jameshadfield deleted the james/treetime-exit-code branch December 20, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants