-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CLI params normalization #5661
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a test that validates the solution
I have updated the tests accordingly |
Not following much, the issue says
I would expect, the test to validate the correct behaviour, instead only add quotes to some numeric values |
Check again, it also changed |
Continue to not understand how the test validates the fix for the defect reported. |
Discussed internally. Here's the red-green analysis to show how the unit test captures the original problem. Without the changes to CmdRun, the test fails as follows:
Note that With the changes to CmdRun, the tests pass as shown in CI. |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Close #5655