-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve attributes of published files (take 2) #5660
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Tagging @jordeu for visibility? Does Fusion honour the copy of file timestamps? |
If the copy attributes is only honoured by local and shared file system, we should consider making this an opt-in feature, because it's not a portable behaviour. In alternative, instead of copying the file stamps, it could be tried to copy the files ordering them by timestamp. Even if the timestamp would be different it may guarantee they are consistent with expectation of the tool reported in the issue (tho is should be verified the the timestamp is set when stating the upload or when it completes). |
I don't think re-ordering the publish operations will matter because they are published concurrently |
Yeah, ordering was more a random thought |
To recap here, since this rule cannot be generalised |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
modules/nextflow/src/main/groovy/nextflow/processor/PublishDir.groovy
Outdated
Show resolved
Hide resolved
plugins/nf-amazon/src/main/nextflow/cloud/aws/nio/S3FileSystemProvider.java
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/processor/PublishDir.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman Am I wrong or there has been a regression after last changes? |
The last two commits with CI failures report errors with the bitbucket integration:
I don't see how it could be related to this PR, seems like something wrong with bitbucket creds or some networking issue |
Tests are passing now |
Nice |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Continuation of #4522
Allow COPY_ATTRIBUTES on S3 copy as a no-op, so that this attribute can be set generically when publishing files.
For some reason this issue did not surface in the previous PR but only once the PR was merged