Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multiple git revisions (Jan-Apr 2024) : temporary, using revision name in repo localPath #5087

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

Enable multiple git revisions (Jan-Apr 2024) : temporary, using revision name in repo localPath #5087

wants to merge 58 commits into from

Conversation

marcodelapierre
Copy link
Member

@marcodelapierre marcodelapierre commented Jun 24, 2024 •
edited
Loading

This is spawned out of #4659 .

Original attempt, using revisions not commit IDs, in localPath (as per original thread).

This PR is for the record and for reference, unlikely to go forward.

Pros:

  • simple implementation

Cons:

  • if project is updated, running pipelines with same project will see underlying pipeline files change during the run. Troublesome when using run -latest and in multi-user settings
  • AssetManager instantiates itself circularly to gather info on default branch (to avoid local duplication of default branch directories)

@pditommaso for visibility.

marcodelapierre and others added 30 commits January 15, 2024 17:29
@marcodelapierre
Multiple revisions 1st: AssetManager, Cmd Clone Pull Run
7d027ec 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
removed revision paramter from clone pull run
106e8df 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
updated unit tests for AssetManager
0a9e6f8 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Merge branch 'master' into add/mult_revisions
37d332e
@marcodelapierre
AssetManager provider.revision assigned at AssetManager object creation
5a9b159 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Codespell typo in changelog
94d34f3 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
AssetManager: removed checkout method
4744774 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Merge branch 'master' into add/mult_revisions
d9e7b2b
@marcodelapierre
assetmanager: fixed build signature, and unit tests
08718ef 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
assetmanager: one more build signature fix
242a600 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
AssetManager: fix for multi revs in find() method
35ad1e9 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Multiple revisions: added for Cmds Drop, View, Config, Info
463b6f1 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
minor fixes to log outputs in CmdRun
2d3273e 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
AssetManager: documented new localPath schema
d2e5ffe 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
K8sDriverLauncher : added revision support
60c3c5e 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
updates to AssetManagerTest
4bf1e37 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
edit to AssetManagerTest, git.pull for TAGS does not output result of…
7e32111 
… operation

Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
minor fix in GitlabRepositoryProvider: using DEFAULT_BRANCH instead o…
3b2d461 
…f "master"

Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@bentsherman
Minor edits
2e6461e 
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@marcodelapierre
Merge branch 'master' into add/mult_revisions
a8d2dee
@pditommaso
[ci fast] Merge branch 'master' into add/mult_revisions
eaf45d8
@marcodelapierre
Merge branch 'master' into add/mult_revisions
ed17284
@marcodelapierre
parametrised revision delimiter
b3f141d 
Signed-off-by: Dr Marco De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
nf pull: option to list or not revs for each project
6706bd9 
Signed-off-by: Dr Marco De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
nicer output for nf list -r
e62f543 
Signed-off-by: Dr Marco De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
minor edit to CmdList
bd19877 
Signed-off-by: Dr Marco De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
AssetManager: adding listRevisions method (work in progress)
c0268af 
Signed-off-by: Dr Marco De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
small tune to CmdList
aae2afc 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
minor tweak to CmdList
268ec79 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
AssetManager: listRevisions method now working
ac8d755 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
marcodelapierre and others added 25 commits March 4, 2024 12:08
@marcodelapierre
docs - cli: add/update -r option for relevant commands
e4b9d78 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
CmdInfo: now also prints info on pulled revisions
958955a 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
CmdInfo made smarter when non only non default revisions pulled
f220e98 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
CmdInfoTest updated
2ad9a24 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
CmdInfoTest fix
35ea812 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
CmdInfo: added code comment
80ecacd 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
AssetManager: default revision recognised correctly if specified in m…
5e4b45f 
…anifest

Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
small CLI Docs update
aa94d7b 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
added a couple of comments
d965ee5 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Merge branch 'master' into add/mult_revisions
f6e6174
@pditommaso
Merge branch 'master' into add/mult_revisions
ca48a97
@marcodelapierre
fix merge conflicts
12d31a2 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Review: REVISION_DELIM and added comments
9aacb2b 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
review: added method getProjectWithRevision
12718c7 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
updated method getBaseNameWithRevision
0b57262 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
docs/sharing: added paragraph on multiple revisions, with caveat on r…
17067ea 
…eproducibility

Signed-off-by: Dr Marco De La Pierre <marco.delapierre@gmail.com>
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
cmd info: removed sticky current revision, updated docs
67dc5d5 
Signed-off-by: Dr Marco De La Pierre <marco.delapierre@gmail.com>
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
fixed unit tests in CmdInfoTest
7716416 
Signed-off-by: Dr Marco De La Pierre <marco.delapierre@gmail.com>
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Merge branch 'master' into add/mult_revisions
45be84b 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
merged from master
2af4ba7 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Merge branch 'master' into add/mult_revisions
afa8a1c 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Merge branch 'master' into add/mult_revisions
dc4bdee 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Merge branch 'master' into add/mult_revisions_apr_revision_path
4c93b3e 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
AssetManager: revert back to set revision in checkValidRemoteRepo()
77b55f3 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre
Merge branch 'master' into add/mult_revisions_apr_revision_path
4cd7793 
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
@marcodelapierre marcodelapierre requested a review from a team as a code owner June 24, 2024 08:53
@marcodelapierre marcodelapierre self-assigned this Jun 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 24, 2024 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 4cd7793
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/6679341209af39000854953a
😎 Deploy Preview https://deploy-preview-5087--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcodelapierre marcodelapierre mentioned this pull request Jun 24, 2024
Draft
@marcodelapierre marcodelapierre changed the title Enable multiple git revisions (Jan-Apr 2024) : using revision name in repo localPath Enable multiple git revisions (Jan-Apr 2024) : temporary, using revision name in repo localPath Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcodelapierre marcodelapierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcodelapierre @bentsherman @pditommaso