Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop account export and import #46

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Drop account export and import #46

merged 1 commit into from
Mar 7, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Mar 1, 2022

Drop account export and import in favour of nextcloud/server#31382

@Pytal Pytal added 3. to review Waiting for reviews enhancement New feature request labels Mar 1, 2022
@Pytal Pytal requested a review from come-nc March 1, 2022 04:26
@Pytal Pytal self-assigned this Mar 1, 2022
@come-nc
Copy link
Collaborator

come-nc commented Mar 1, 2022

We should not treat it as a special case and just register it in core.

@Pytal
Copy link
Member Author

Pytal commented Mar 1, 2022

We should not treat it as a special case and just register it in core.

There are currently no RegistrationContext registrations being done in core so there was no clear place for this, @ChristophWurst any recommendation for where this should go?

@Pytal
Copy link
Member Author

Pytal commented Mar 2, 2022

We should not treat it as a special case and just register it in core.

There are currently no RegistrationContext registrations being done in core so there was no clear place for this, @ChristophWurst any recommendation for where this should go?

@juliushaertl @nickvergessen any recommendations on making RegistrationContext registrations in core?

@juliushaertl
Copy link
Member

Not fully sure I get the question correctly, let me know if not - but in order to allow registration in the core RegistrationContext, you'd need to extend those parts in the server. https://github.com/nextcloud/server/pull/21850/files#diff-6f7fce46b3b19b872adcab3426e155b80766fd2b10feabc70ae29cbac2433a40 might be a good inspiration code wise.

@Pytal
Copy link
Member Author

Pytal commented Mar 3, 2022

@juliushaertl yes the registration plumbing was done in https://github.com/nextcloud/server/pull/30901/files

For clarification, by registrations in core I meant registering i.e. calling registerUserMigrator() in core and was wondering whether or not this would be doable within the existing bootstrapping code? as I looked through all the calls for the register methods of https://github.com/nextcloud/server/blob/master/lib/private/AppFramework/Bootstrap/RegistrationContext.php and https://github.com/nextcloud/server/blob/master/lib/public/AppFramework/Bootstrap/IRegistrationContext.php and all registrations are done in an app rather than core

@nickvergessen
Copy link
Member

What would be the goal of this? Maybe you can do it in the settings app when it's about the user's settings or something? So there is always an app that does it?

On the other hand there is a never ending techdebt issue whether the core "app" should be turned into a full app.

@Pytal
Copy link
Member Author

Pytal commented Mar 4, 2022

What would be the goal of this? Maybe you can do it in the settings app when it's about the user's settings or something? So there is always an app that does it?

On the other hand there is a never ending techdebt issue whether the core "app" should be turned into a full app.

The goal is to put the migrators close to the classes they depend on i.e. AccountMigrator deals with account data which is handled by the classes in lib/private/Accounts/ so placing the migrator there would be ideal

For the purposes of registration then yes I think the settings app would be the best app to put this into so will go with that, the techdebt looms large 💀

@Pytal Pytal changed the title Run account migrator Drop account handling Mar 4, 2022
@Pytal Pytal changed the title Drop account handling Drop account export and import Mar 4, 2022
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@come-nc come-nc merged commit b1a2889 into main Mar 7, 2022
@come-nc come-nc deleted the enh/account-migrator branch March 7, 2022 09:54
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 7, 2022
@come-nc come-nc added this to the 0.1 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants