-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop account export and import #46
Conversation
We should not treat it as a special case and just register it in core. |
There are currently no RegistrationContext registrations being done in core so there was no clear place for this, @ChristophWurst any recommendation for where this should go? |
@juliushaertl @nickvergessen any recommendations on making RegistrationContext registrations in core? |
Not fully sure I get the question correctly, let me know if not - but in order to allow registration in the core RegistrationContext, you'd need to extend those parts in the server. https://github.com/nextcloud/server/pull/21850/files#diff-6f7fce46b3b19b872adcab3426e155b80766fd2b10feabc70ae29cbac2433a40 might be a good inspiration code wise. |
@juliushaertl yes the registration plumbing was done in https://github.com/nextcloud/server/pull/30901/files For clarification, by registrations in core I meant registering i.e. calling |
What would be the goal of this? Maybe you can do it in the settings app when it's about the user's settings or something? So there is always an app that does it? On the other hand there is a never ending techdebt issue whether the core "app" should be turned into a full app. |
The goal is to put the migrators close to the classes they depend on i.e. AccountMigrator deals with account data which is handled by the classes in For the purposes of registration then yes I think the settings app would be the best app to put this into so will go with that, the techdebt looms large 💀 |
7daa0a2
to
9ee9cf4
Compare
9ee9cf4
to
a342561
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
a342561
to
9b424cb
Compare
Drop account export and import in favour of nextcloud/server#31382