Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User account migration #31382

Merged
merged 7 commits into from
Mar 22, 2022
Merged

User account migration #31382

merged 7 commits into from
Mar 22, 2022

Conversation

@Pytal Pytal added enhancement 3. to review Waiting for reviews feature: user migration Related to User migration labels Mar 1, 2022
@Pytal Pytal added this to the Nextcloud 24 milestone Mar 1, 2022
@Pytal Pytal requested review from come-nc and a team March 1, 2022 04:13
@Pytal Pytal self-assigned this Mar 1, 2022
@Pytal Pytal requested review from PVince81 and CarlSchwan and removed request for a team March 1, 2022 04:13
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should also take care of registering the migrator.

lib/private/Accounts/AccountMigrator.php Outdated Show resolved Hide resolved
lib/private/Accounts/AccountMigrator.php Outdated Show resolved Hide resolved
lib/private/Accounts/AccountMigrator.php Outdated Show resolved Hide resolved
lib/private/Accounts/AccountMigrator.php Outdated Show resolved Hide resolved
lib/private/Accounts/AccountMigratorException.php Outdated Show resolved Hide resolved
@Pytal Pytal force-pushed the feat/account-migrator branch 2 times, most recently from 7014a0f to 5e345b5 Compare March 3, 2022 05:48
@Pytal

This comment was marked as resolved.

@Pytal Pytal marked this pull request as draft March 3, 2022 05:53
@Pytal Pytal force-pushed the feat/account-migrator branch 2 times, most recently from 5a343ed to ec15a1e Compare March 4, 2022 19:11
@Pytal

This comment was marked as resolved.

@Pytal
Copy link
Member Author

Pytal commented Mar 18, 2022

Ready for review after all required PRs have got in

@Pytal Pytal requested a review from come-nc March 18, 2022 04:11
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that as this migrator is now in the settings app it should import/export from a folder named after settings Application::APP_ID.
This makes it consistent with other migrators, and avoids people taking inspiration from this migrator to put things at the archive export root folder.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@come-nc come-nc merged commit 58582df into master Mar 22, 2022
@come-nc come-nc deleted the feat/account-migrator branch March 22, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: user migration Related to User migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants