fix: use php 8.1 as that is required now #3610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <max@nextcloud.com>
|
I think current master is segfaulting with php 7.4, 8.0 and 8.1. I'll try to spin up a current master in my local dev env. |
That worked fine 🤔 |
|
max-nextcloud
force-pushed
the
fix/cypress-php-version
branch
from
567c79d
to
bba0343
Compare
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
max-nextcloud
force-pushed
the
fix/cypress-php-version
branch
from
bba0343
to
0453842
Compare
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/cypress-php-version
branch
from
c9ce2c1
to
a38aa6e
Compare
lets see if the segfault happens in the generateAvatarFromSvg function. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/cypress-php-version
branch
2 times, most recently
from
b841123
to
af9d301
Compare
|
Closing as the server PR was reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary