avatar generation - disable setimageformat

[szaimen]

Fix #34755

See #34755 (comment) and #34755 (comment) for context

[szaimen]

/backport to stable25

[juliushaertl]

This actually causes segfaults on cypress tests when creating a new user in text. nextcloud/text#3610 (comment)

@szaimen Do you have any further technical insights on why the png conversion failed? The segfault is also weird, but more elaboration on this fix would be good. Is the Imagick format now kept as svg? In that case OC_Image further down

server/lib/private/Avatar/Avatar.php

Line 141 in a0f2180

$image->loadFromData((string)$avatar);

would receive an svg which GD cannot handle. So maybe this just hides the issue and uses the fallback from

server/lib/private/Avatar/UserAvatar.php

Line 245 in f98ae2b

$data = $this->generateAvatar($this->getDisplayName(), 1024, $darkTheme);

?

[juliushaertl]

I actually also have the segfault on my dev instance. It happens when trying to get the image data from imagick using (string)$avatar without setting a format. Would vote to revert this and rather try to check for the reason why the generation fails originally.

[juliushaertl]

@szaimen Since you could reproduce the original issue can you maybe try if the following patch works instead of this one?

diff --git a/lib/private/Avatar/Avatar.php b/lib/private/Avatar/Avatar.php
index 791cb8b2e7f..fcec7f2dd27 100644
--- a/lib/private/Avatar/Avatar.php
+++ b/lib/private/Avatar/Avatar.php
@@ -126,7 +126,7 @@ abstract class Avatar implements IAvatar {
         * Generate png avatar from svg with Imagick
         */
        protected function generateAvatarFromSvg(int $size, bool $darkTheme): ?string {
-               if (!extension_loaded('imagick')) {
+               if (!extension_loaded('imagick') || count(\Imagick::queryFormats('SVG')) === 0) {
                        return null;
                }
                try {

[szaimen]

Since you could reproduce the original issue can you maybe try if the following patch works instead of this one?

diff --git a/lib/private/Avatar/Avatar.php b/lib/private/Avatar/Avatar.php
index 791cb8b2e7f..fcec7f2dd27 100644
--- a/lib/private/Avatar/Avatar.php
+++ b/lib/private/Avatar/Avatar.php
@@ -126,7 +126,7 @@ abstract class Avatar implements IAvatar {
         * Generate png avatar from svg with Imagick
         */
        protected function generateAvatarFromSvg(int $size, bool $darkTheme): ?string {
-               if (!extension_loaded('imagick')) {
+               if (!extension_loaded('imagick') || count(\Imagick::queryFormats('SVG')) === 0) {
                        return null;
                }
                try {

I tried it but it doesnt work. This is the generated avatar picture:

So maybe it is indeed a font problem? However I don't understand why...

[szaimen]

I think I might have found the issue.

[szaimen]

It might be indeed an AIO issue: nextcloud/all-in-one#1624