Remove superfluous scrollbar caused by menububble #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azul
commented
Oct 20, 2021
When the menububble is prepared it is rendered at the bottom of the page and hidden. The `margin-bottom: -3px` causes it to create a scrollbar. Once the menububble is shown it is positioned on the screen and the scrollbar is gone. So only apply the `margin-bottom: -3px` when the menububble is shown. Signed-off-by: Azul <azul@riseup.net>
azul
force-pushed
the
azul/fix-1572-superfluous-scrollbar
branch
from
2f4f6ba
to
243afb2
Compare
delete-merged-branch
bot
deleted the
azul/fix-1572-superfluous-scrollbar
branch
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
margin-bottom: -3pxin the menububble #1572Summary
When the menububble is prepared
it is rendered at the bottom of the page and hidden.
The
margin-bottom: -3pxcauses it to create a scrollbar.Once the menububble is shown
it is positioned on the screen
and the scrollbar is gone.
So only apply the
margin-bottom: -3pxwhen the menububble is shown.