Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: superflouis scrollbar due to margin-bottom: -3px in the menububble #1572

Closed
mejo- opened this issue Apr 26, 2021 · 2 comments · Fixed by #1902
Closed

Regression: superflouis scrollbar due to margin-bottom: -3px in the menububble #1572

mejo- opened this issue Apr 26, 2021 · 2 comments · Fixed by #1902
Labels
bug Something isn't working

Comments

@mejo-
Copy link
Member

mejo- commented Apr 26, 2021

Describe the bug
Since commit 7b4ab74, a superfluous scrollbar is displayed next to the text editor. That's due to (inactive) MenuBubble being displayed with margin-bottom: -3px at the bottom of the editor container. This seems to steal some space from the editor container, which results in the scrollbar that allows scrolling 3 pixels 😉

I didn't understand the reason for margin-bottom: -3px in the first place. In fact, even the active MenuBubble looks cleaner with margin-bottom: 0px in my tests - the small space between selected text and the AddLink/LinkFile MenuBubble makes it look cleaner. So my suggestion would be to remove margin-bottom: -3px altogether 😉

Client details:

  • OS: Debian Bullseye
  • Browser: Firefox 88.0, Chromium 89.0
  • Version: NC branch stable21, Text branch stable21
@mejo- mejo- added the bug Something isn't working label Apr 26, 2021
@mejo-
Copy link
Member Author

mejo- commented Apr 26, 2021

We temporarily fixed this in the Collectives App with the following commit: https://gitlab.com/collectivecloud/collectives/-/commit/653e7df3c571f84ae62f74a60303489c629eccfc

@azul
Copy link
Contributor

azul commented Oct 20, 2021

Removing the margin-bottom changes the style somewhat:

with margin-bottom:
Bildschirmfoto von 2021-10-20 10-24-11

without margin-bottom:
Bildschirmfoto von 2021-10-20 10-26-30

The scrollbar also goes away once the menu bubble is shown for the first time. Leading to some realignment of the viewer. This is because at first the menu-bubble is displayed at the bottom of the page but hidden. With the margin bottom this creates the scrollbar. Once it is moved to actually be displayed the margin bottom is not a problem anymore.

I think i will tackle this by only applying the margin-bottom if the menubar is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants