Skip to content

Commit

Permalink
fix unit tests
Browse files Browse the repository at this point in the history
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
  • Loading branch information
Florian Steffens committed Aug 10, 2023
1 parent 9c0503e commit c318e84
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions tests/unit/Service/PermissionsServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

use OCA\Tables\Db\ShareMapper;
use OCA\Tables\Db\TableMapper;
use OCA\Tables\Db\ViewMapper;
use OCA\Tables\Errors\InternalError;
use OCA\Tables\Helper\UserHelper;
use Psr\Log\LoggerInterface;
Expand All @@ -39,8 +40,9 @@ public function testPreCheckUserIdGivenUser() {
$userId = "TestUser";
$tableMapper = $this->createMock(TableMapper::class);
$shareMapper = $this->createMock(ShareMapper::class);
$viewMapper = $this->createMock(ViewMapper::class);
$userHelper = $this->createMock(UserHelper::class);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, false);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, false);

self::assertEquals($userId, $permissionsService->preCheckUserId($userId));
}
Expand All @@ -49,9 +51,10 @@ public function testPreCheckUserIdNoUser() {
$logger = $this->createMock(LoggerInterface::class);
$userId = null;
$tableMapper = $this->createMock(TableMapper::class);
$viewMapper = $this->createMock(ViewMapper::class);
$shareMapper = $this->createMock(ShareMapper::class);
$userHelper = $this->createMock(UserHelper::class);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, false);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, false);

self::expectException(InternalError::class);
$permissionsService->preCheckUserId($userId);
Expand All @@ -61,9 +64,10 @@ public function testPreCheckUserIdNoUserButContext() {
$logger = $this->createMock(LoggerInterface::class);
$userId = 'john';
$tableMapper = $this->createMock(TableMapper::class);
$viewMapper = $this->createMock(ViewMapper::class);
$shareMapper = $this->createMock(ShareMapper::class);
$userHelper = $this->createMock(UserHelper::class);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, false);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, false);

self::assertEquals($userId, $permissionsService->preCheckUserId(null));
}
Expand All @@ -72,9 +76,10 @@ public function testPreCheckUserIdNoUserNotAllowed() {
$logger = $this->createMock(LoggerInterface::class);
$userId = '';
$tableMapper = $this->createMock(TableMapper::class);
$viewMapper = $this->createMock(ViewMapper::class);
$shareMapper = $this->createMock(ShareMapper::class);
$userHelper = $this->createMock(UserHelper::class);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, false);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, false);

self::expectException(InternalError::class);
$permissionsService->preCheckUserId($userId, false);
Expand All @@ -87,9 +92,10 @@ public function testPreCheckUserIdNoUserAllowed() {
$logger = $this->createMock(LoggerInterface::class);
$userId = '';
$tableMapper = $this->createMock(TableMapper::class);
$viewMapper = $this->createMock(ViewMapper::class);
$shareMapper = $this->createMock(ShareMapper::class);
$userHelper = $this->createMock(UserHelper::class);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $shareMapper, $userHelper, true);
$permissionsService = new PermissionsService($logger, $userId, $tableMapper, $viewMapper, $shareMapper, $userHelper, true);

self::assertEquals($userId, $permissionsService->preCheckUserId($userId));
}
Expand Down

0 comments on commit c318e84

Please sign in to comment.