code cleanup

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
nextcloud · Aug 10, 2023 · 9c0503e · 9c0503e
1 parent cdaaec9
commit 9c0503e
Show file tree

Hide file tree

Showing 26 changed files with 184 additions and 548 deletions.
diff --git a/lib/Api/V1Api.php b/lib/Api/V1Api.php
@@ -3,12 +3,9 @@
 namespace OCA\Tables\Api;
 
 use OCA\Tables\Errors\InternalError;
-use OCA\Tables\Errors\NotFoundError;
 use OCA\Tables\Errors\PermissionError;
 use OCA\Tables\Service\ColumnService;
 use OCA\Tables\Service\RowService;
-use OCP\AppFramework\Db\DoesNotExistException;
-use OCP\AppFramework\Db\MultipleObjectsReturnedException;
 
 class V1Api {
 	private RowService $rowService;

diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
@@ -8,11 +8,9 @@
 use OCA\Tables\Listener\AnalyticsDatasourceListener;
 use OCA\Tables\Listener\TablesReferenceListener;
 use OCA\Tables\Listener\UserDeletedListener;
-use OCA\Tables\Reference\LegacyReferenceProvider;
-use OCA\Tables\Reference\RowReferenceProvider;
 use OCA\Tables\Reference\ContentReferenceProvider;
+use OCA\Tables\Reference\LegacyReferenceProvider;
 use OCA\Tables\Reference\ReferenceProvider;
-use OCA\Tables\Reference\ViewReferenceProvider;
 use OCA\Tables\Search\SearchTablesProvider;
 use OCP\AppFramework\App;
 use OCP\AppFramework\Bootstrap\IBootContext;

diff --git a/lib/Controller/Api1Controller.php b/lib/Controller/Api1Controller.php
@@ -510,7 +510,7 @@ public function createRowInView(
 			];
 		}
 
-		return $this->handleError(function () use ( $viewId, $dataNew) {
+		return $this->handleError(function () use ($viewId, $dataNew) {
 			return $this->rowService->create(null, $viewId, $dataNew);
 		});
 	}
@@ -553,8 +553,8 @@ public function getRow(int $rowId): DataResponse {
 	 * @NoCSRFRequired
 	 */
 	public function updateRow(int $rowId,
-							  ?int $viewId,
-							  array $data): DataResponse {
+		?int $viewId,
+		array $data): DataResponse {
 		$dataNew = [];
 		foreach ($data as $key => $value) {
 			$dataNew[] = [

diff --git a/lib/Controller/SearchController.php b/lib/Controller/SearchController.php
@@ -3,7 +3,6 @@
 namespace OCA\Tables\Controller;
 
 use OCA\Tables\AppInfo\Application;
-use OCA\Tables\Service\ImportService;
 use OCA\Tables\Service\SearchService;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\DataResponse;

diff --git a/lib/Db/ShareMapper.php b/lib/Db/ShareMapper.php
@@ -15,7 +15,7 @@ class ShareMapper extends QBMapper {
 	protected string $table = 'tables_shares';
 	protected LoggerInterface $logger;
 
-	public function __construct( LoggerInterface $logger, IDBConnection $db) {
+	public function __construct(LoggerInterface $logger, IDBConnection $db) {
 		parent::__construct($db, $this->table, Share::class);
 		$this->logger = $logger;
 	}

diff --git a/lib/Reference/LegacyReferenceProvider.php b/lib/Reference/LegacyReferenceProvider.php
@@ -3,21 +3,18 @@
 namespace OCA\Tables\Reference;
 
 use OC\Collaboration\Reference\ReferenceManager;
-use OCA\Tables\AppInfo\Application;
-use OCP\Collaboration\Reference\ADiscoverableReferenceProvider;
 use OCP\Collaboration\Reference\IReference;
 use OCP\Collaboration\Reference\IReferenceProvider;
-use OCP\Collaboration\Reference\ISearchableReferenceProvider;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 
 class LegacyReferenceProvider implements IReferenceProvider {
-	private TableReferenceHelper $referenceHelper;
+	private ReferenceHelper $referenceHelper;
 	private ReferenceManager $referenceManager;
 	private IURLGenerator $urlGenerator;
 	private IL10N $l10n;
 
-	public function __construct(IL10N $l10n, IURLGenerator $urlGenerator, TableReferenceHelper $referenceHelper, ReferenceManager $referenceManager) {
+	public function __construct(IL10N $l10n, IURLGenerator $urlGenerator, ReferenceHelper $referenceHelper, ReferenceManager $referenceManager) {
 		$this->referenceHelper = $referenceHelper;
 		$this->referenceManager = $referenceManager;
 		$this->urlGenerator = $urlGenerator;

diff --git a/lib/Reference/ReferenceProvider.php b/lib/Reference/ReferenceProvider.php
@@ -6,7 +6,6 @@
 use OCA\Tables\AppInfo\Application;
 use OCP\Collaboration\Reference\ADiscoverableReferenceProvider;
 use OCP\Collaboration\Reference\IReference;
-use OCP\Collaboration\Reference\IReferenceProvider;
 use OCP\Collaboration\Reference\ISearchableReferenceProvider;
 use OCP\IL10N;
 use OCP\IURLGenerator;

diff --git a/lib/Reference/stuff/RowReferenceHelper.php b/lib/Reference/stuff/RowReferenceHelper.php
diff --git a/lib/Reference/stuff/RowReferenceProvider.php b/lib/Reference/stuff/RowReferenceProvider.php