Enable helper app with force #7218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to not bump the version in the helper app anymore. Will save me a roundtrip of CI every time we branch off as I always forget it. Also notifications and guests server requirement are of no interest to us. Signed-off-by: Joas Schilling <coding@schilljs.com>
|
Just for the record, the only thing |
|
@danxuliu thoughts? |
danxuliu
reviewed
Apr 27, 2022
There was a problem hiding this comment.
For the helper app I guess it is fine. For the other apps I am not a fan, as it could lead to forgetting to set the right branch on the stableXX branches due to forcing the installation of the master branch. Also in the master branch, if the apps are not actually compatible yet, we could still have a red CI, but with stranger errors rather than a failure when enabling the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to not bump the version in the helper app anymore.
Will save me a roundtrip of CI every time we branch off as I always forget it.
Also notifications and guests server requirement are of no interest to us and instead of having troubles during the transition period with red CI we just force enable them too.