Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable helper app with force #1191

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Enable helper app with force #1191

merged 2 commits into from
Apr 28, 2022

Conversation

nickvergessen
Copy link
Member

This allows to not bump the version in the helper app anymore.
Will save me a roundtrip of CI every time we branch off as I always forget it.

Similar to nextcloud/spreed#7218

@nickvergessen
Enable helper app with force
13ba14d 
This allows to not bump the version in the helper app anymore.
Will save me a roundtrip of CI every time we branch off as I always forget it.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Apr 25, 2022
@nickvergessen nickvergessen requested a review from danxuliu April 25, 2022 20:02
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9619 was 9300 (+3.43%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen
Print query.log
96a982a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9641 was 9300 (+3.66%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

danxuliu
danxuliu reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that forcing the installation of the helper app is fine. But I would say that the version should still be bumped, otherwise in the future it could be misleading if someone looks into the info.xml and sees that it has not been updated for several versions.

@nickvergessen nickvergessen merged commit 318a601 into master Apr 28, 2022
@nickvergessen nickvergessen deleted the techdebt/noid/enable-helper-app-with-force branch April 28, 2022 04:45
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @danxuliu