Catch the errors related to untrusted self signed certificates for federation #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
approved these changes
Dec 11, 2017
…deration * Added tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
force-pushed
the
log_correct_self_signed
branch
from
14a13ae
to
2c2e1c4
Compare
|
Rebased to contain the fixes from master. |
Codecov Report
@@ Coverage Diff @@
## master #7450 +/- ##
============================================
- Coverage 51.08% 50.79% -0.29%
- Complexity 24858 25074 +216
============================================
Files 1596 1596
Lines 94590 95156 +566
Branches 1367 1367
============================================
+ Hits 48317 48334 +17
- Misses 46273 46822 +549
|
|
@blizzz @ChristophWurst @skjnldsv I would like to have this in the beta 2 as well. |
ChristophWurst
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in our sentry setup.
Basically catch more generic exceptions. As well as the ringexceptions. They basically can happen for some weird curl reasons. Just catch them and log. Since the admin can't help what curl is getting back anyway.