Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop all dead packages #24816

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Drop all dead packages #24816

merged 1 commit into from
Dec 23, 2020

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 22, 2020 •
edited
Loading

Apparently we have plenty of leftover of previous sub-dependencies.
Composer automatically dumps those with any future dependency update, so
I'm dropping them in an atomic step.

@ChristophWurst ChristophWurst added this to the Nextcloud 21 milestone Dec 22, 2020
@ChristophWurst ChristophWurst self-assigned this Dec 22, 2020
@ChristophWurst ChristophWurst mentioned this pull request Dec 22, 2020
Merged
@ChristophWurst

This comment has been minimized.

Sign in to view
@ChristophWurst
Copy link
Member Author

The only code where we use the dead packages is the ring exception handling introduced with #7450. @rullzer if the ring thingy isn't even used I guess we can undo the specific exception handling, right?

@ChristophWurst
Drop all dead packages
1e0eaa2 
Apparently we have plenty of leftover of previous sub-dependencies.
Composer automatically dumps those with any future dependency update, so
I'm dropping them in an atomic step.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@rullzer rullzer mentioned this pull request Dec 23, 2020
Merged
39 tasks
@juliushaertl juliushaertl merged commit 5b61120 into master Dec 23, 2020
@juliushaertl juliushaertl deleted the techdept/dead-packages branch December 23, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@danxuliu danxuliu Awaiting requested review from danxuliu

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @rullzer @juliushaertl