-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(settings): Clarify peculiarities of enabling encryption #50424
Conversation
/backport to stable31 |
c60013b
to
94e1323
Compare
/compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Clarify that enabling server side encryption will not encrypt existing files but only new or changed files. - Clarify that server side encryption can only be disabled using OCC - Ensure there is accessible information of encryption state (`disabled` input will not be announced so make it `aria-disabled` instead) - Make warning more prominent by moving it into a dialog Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
89d83ba
to
78bec6f
Compare
Makes sense ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again and LGTM
Just as an idea: we could even disable the switch to enable SSE if the encryption module is not enabled, no?
/backport to stable30 |
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/50424/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cdaeb638 78bec6f4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50424/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/50424/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cdaeb638 78bec6f4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50424/stable30 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport cdaeb63 to stable30 |
/backport cdaeb63 to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/50424/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cdaeb638
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50424/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/50424/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cdaeb638
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50424/stable30 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
disabled
input will not be announced so make itaria-disabled
instead)Screenshots
Checklist