Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Clarify peculiarities of enabling encryption #50424

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 25, 2025

Summary

  • Clarify that enabling server side encryption will not encrypt existing files but only new or changed files.
  • Clarify that server side encryption can only be disabled using OCC
  • Ensure there is accessible information of encryption state (disabled input will not be announced so make it aria-disabled instead)
  • Make warning more prominent by moving it into a dialog

Screenshots

before after
Screenshot 2025-01-25 at 14-09-52 Security - Administration settings - Nextcloud Screenshot 2025-01-25 at 14-10-35 Security - Administration settings - Nextcloud
Screenshot 2025-01-25 at 14-11-53 Security - Administration settings - Nextcloud Screenshot 2025-01-25 at 14-11-32 Security - Administration settings - Nextcloud

Checklist

@susnux susnux added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: encryption (server-side) labels Jan 25, 2025
@susnux susnux added this to the Nextcloud 32 milestone Jan 25, 2025
@susnux susnux requested review from artonge, nfebe, Pytal and szaimen January 25, 2025 13:15
@susnux susnux added the bug label Jan 25, 2025
@susnux
Copy link
Contributor Author

susnux commented Jan 25, 2025

/backport to stable31

@joshtrichards
Copy link
Member

Related:

#40468
#48829
#49200

@susnux susnux force-pushed the fix/encryption-text branch from c60013b to 94e1323 Compare January 27, 2025 14:12
@susnux
Copy link
Contributor Author

susnux commented Jan 27, 2025

/compile

@susnux susnux enabled auto-merge January 27, 2025 14:13
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM so far but did not review the code.

However shouldnt we check the following requirement before we allow to enable the SSE?
(This hint is only displayed after the SSE was activated)
image

- Clarify that enabling server side encryption will not encrypt
  existing files but only new or changed files.
- Clarify that server side encryption can only be disabled using OCC
- Ensure there is accessible information of encryption state (`disabled`
  input will not be announced so make it `aria-disabled` instead)
- Make warning more prominent by moving it into a dialog

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/encryption-text branch from 89d83ba to 78bec6f Compare January 31, 2025 15:44
@susnux
Copy link
Contributor Author

susnux commented Jan 31, 2025

However shouldnt we check the following requirement before we allow to enable the SSE?

Makes sense ✅

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and LGTM

Just as an idea: we could even disable the switch to enable SSE if the encryption module is not enabled, no?

@susnux
Copy link
Contributor Author

susnux commented Jan 31, 2025

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Jan 31, 2025

/backport to stable29

Copy link

backportbot bot commented Jan 31, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/50424/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cdaeb638 78bec6f4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50424/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jan 31, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/50424/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cdaeb638 78bec6f4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50424/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor Author

susnux commented Jan 31, 2025

/backport cdaeb63 to stable30

@susnux
Copy link
Contributor Author

susnux commented Jan 31, 2025

/backport cdaeb63 to stable29

Copy link

backportbot bot commented Jan 31, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/50424/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cdaeb638

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50424/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jan 31, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/50424/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cdaeb638

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50424/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enh(Settings): Provide visual feedback to user when encryption app not installed.
4 participants