Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(Settings): Provide visual feedback to user when encryption app not installed. #48829

Closed
nfebe opened this issue Oct 21, 2024 · 2 comments · Fixed by #50424
Closed

enh(Settings): Provide visual feedback to user when encryption app not installed. #48829

nfebe opened this issue Oct 21, 2024 · 2 comments · Fixed by #50424

Comments

@nfebe
Copy link
Contributor

nfebe commented Oct 21, 2024

Under : Admin settings -> Security, The "Enable server-side encryption", toggle does not do anything unless the "encryption" app is present.

That make sense but it should provide visual feedback as to what is going on.

@solracsf
Copy link
Member

solracsf commented Oct 22, 2024

I know this is not 100% directly related, but in some cases, (sys)admin shoudl be able to completely disable encryption and its activation with config param like 'encryption_available' => false. If this was set to false (default as true) encryption (and its modules) could not be installed (or, at very least, activated) trough the WebUI or the CLI.

In this case, a message should also inform the user that encryption modules can't be installed or enabled because of that flag set.

@nfebe
Copy link
Contributor Author

nfebe commented Nov 11, 2024

I know this is not 100% directly related, but in some cases, (sys)admin shoudl be able to completely disable encryption and its activation with config param like 'encryption_available' => false. If this was set to false (default as true) encryption (and its modules) could not be installed (or, at very least, activated) trough the WebUI or the CLI.

In this case, a message should also inform the user that encryption modules can't be installed or enabled because of that flag set.

I have added a draft that moves towards something like that in separate pull request here : #49202

Handling that separately allows this to get resolved much faster.

@solracsf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment