fix: Make focused app menu entry wider to see full name #47140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Aug 8, 2024
AndyScherzinger
approved these changes
Aug 8, 2024
|
4grid baseline seems fine to me 👍 |
Merged
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/app-menu-focus
branch
from
faf8176 to
e5bb27c
Compare
|
I changed the value to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes the focused app entry wider while shrinking its neighbors.
In this PR (currently) I use 3grid-baseline, but this is not enough for "Dashboard", do you think 4grid-baseline is ok? Meaning it would grow by 16px to 66px focused entry.
With this PR
Bildschirmaufnahme_20240808_160612.webm
With 4* grid baseline
Bildschirmaufnahme_20240808_161037.webm
Checklist