Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: App name does not show fully on hover/focus of specific app #47101

Closed
4 of 8 tasks
jancborchardt opened this issue Aug 7, 2024 · 8 comments · Fixed by #47140
Closed
4 of 8 tasks

[Bug]: App name does not show fully on hover/focus of specific app #47101

jancborchardt opened this issue Aug 7, 2024 · 8 comments · Fixed by #47140
Assignees
Milestone

Comments

@jancborchardt
Copy link
Member

⚠️ This issue respects the following points: ⚠️

Bug description

Long app names are ellipsized when we could make space for the one that is hovered/focused:
image

Steps to reproduce

  1. Have an app with a comparably long app name installed, e.g. Dashboard (default app), Collectives or Announcements
  2. Notice not the full app name is shown
  3. It doesn’t change when hovering/focusing the app name

Expected behavior

In a previous version, the name of the current app and of the hovered/focused app was expanded to be fully visible:
image

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@jancborchardt jancborchardt added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap regression labels Aug 7, 2024
@jancborchardt jancborchardt moved this to 👓 Design review in 🖍 Design team Aug 7, 2024
@jancborchardt
Copy link
Member Author

So @karlitschek also reported that even Contacts and Calendar are already ellipsized by default (macOS with Safari). Probably we should reduce the default tracking a little bit, or increase the whitespace between the apps a tiny bit?

@susnux @marcoambrosini what do you think?

@susnux
Copy link
Contributor

susnux commented Aug 7, 2024

For calendar we just need a tiny bit more space (the 4px margin removed are enough):
image

But 50px width is not much for text

@susnux
Copy link
Contributor

susnux commented Aug 7, 2024

So yes maybe we should increase the width to 55px?

Or complex solutions:
Option 1: Do not show the neighbor names but instead always show the full app name (so it can not overflow the neighbor)
Option 2: Keep size but make the current focused one 58px by reducing both neighbors by 4px?

Because even 55px is to small for "Dashboard"

@skjnldsv skjnldsv assigned skjnldsv and unassigned skjnldsv Aug 7, 2024
@susnux
Copy link
Contributor

susnux commented Aug 7, 2024

@jancborchardt

I played with option2 and 2x 6px (12px more space as this also fixes dashboard):

before after
Screenshot 2024-08-07 at 12-43-04 Dashboard - Nextcloud Daily Screenshot 2024-08-07 at 12-48-27 Dashboard - Nextcloud Daily

@jancborchardt
Copy link
Member Author

@susnux awesome – yep that’s exactly what I meant, the 2 solutions together are very nice! Meaning removing some margin by default, and having the focused app expand width at the cost of its neighbors.

@susnux susnux self-assigned this Aug 7, 2024
@susnux susnux added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 7, 2024
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 8, 2024
@github-project-automation github-project-automation bot moved this from 👓 Design review to 🎉 Done in 🖍 Design team Aug 8, 2024
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Aug 8, 2024
@karlitschek
Copy link
Member

Screen.Recording.2024-08-09.at.10.16.46.mov

Looks good in general. Unfortunately I see a weird wobbly effect on mouse over

@AndyScherzinger
Copy link
Member

Now that you say it, I also see that wobbly effect. @sorbaugh can you please create a ticket and align with @susnux so it can get fixed for next week's build?

@sorbaugh
Copy link
Contributor

sorbaugh commented Aug 9, 2024

Tracked here :) #47148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants