[stable29] Support excalidraw file type #46711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solracsf
changed the title
juliusknorr
reviewed
Jul 25, 2024
Comment on lines
344
to
350
| $serverVersion = $this->config->getSystemValueString('version', '0.0.0'); | ||
| // 29.0.0.10 is the last version with a mimetype migration before it was moved to a separate version number | ||
| if (version_compare($serverVersion, '29.0.0.10', '>')) { | ||
| return $this->config->getAppValue('files', 'mimetype_version', '29.0.0.10'); | ||
| } | ||
| return $this->config->getSystemValueString('version', '0.0.0'); | ||
|
|
||
| return $serverVersion; |
There was a problem hiding this comment.
We can keep the existing logic and just increase the patch version in apps/files/appinfo/info.xml by one.
hweihwang
requested review from
skjnldsv,
Pytal,
ArtificialOwl,
come-nc,
artonge,
icewind1991,
szaimen,
susnux and
nfebe
as code owners
hweihwang
requested review from
juliusknorr
and removed request for
ArtificialOwl,
icewind1991,
susnux,
artonge,
nfebe,
skjnldsv,
Pytal,
szaimen and
come-nc
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
backport/45353/stable29
branch
from
bceae96 to
d06e5d4
Compare
7 tasks
blizzz
approved these changes
Jul 26, 2024
skjnldsv
approved these changes
Jul 27, 2024
| @@ -354,6 +424,10 @@ public function run(IOutput $out) { | |||
| $out->info('Fixed ReStructured Text mime type'); | |||
| } | |||
|
|
|||
| if (version_compare($mimeTypeVersion, '30.0.0.0', '<') && $this->introduceExcalidrawType()) { | |||
There was a problem hiding this comment.
Should have been adjusted to 29.0.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #45353 to stable29. Adds support for excalidraw file type, including mime type recognition and icon.