-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support excalidraw file #45353
Conversation
29f881f
to
8b84fe9
Compare
c0e470a
to
a7fb83f
Compare
@@ -106,6 +106,14 @@ private function updateMimetypes($updatedMimetypes) { | |||
return $count; | |||
} | |||
|
|||
private function introduceExcalidrawType() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be an opportunity to add return type hint here and in updateMimetypes()
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Tests needs some adjustment it seems:
|
@hweihwang Pushed a small commit to adjust the icon color to match the others. |
9db358a
to
17e3140
Compare
Looks good, cypress seems unrelated, could you squash your commits and rebase to latest master afterwards? Will push my icon fix again then afterwards. |
ea674f3
to
ee66b9f
Compare
ee66b9f
to
86d2094
Compare
@hweihwang Had another conflict in the mean time, could you check? |
86d2094
to
1b193e7
Compare
c78924d
to
906b5f8
Compare
540e2df
to
6da0296
Compare
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
6da0296
to
f5fbe43
Compare
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
/backport to stable29 |
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/45353/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a2f026b f5fbe435
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45353/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/45353/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a2f026b f5fbe435
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45353/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary