Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support excalidraw file #45353

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

hweihwang
Copy link
Contributor

Summary

  • Support new excalidraw file type

@hweihwang hweihwang self-assigned this May 16, 2024
@hweihwang hweihwang force-pushed the feat/excalidraw-file-support branch from 29f881f to 8b84fe9 Compare May 16, 2024 10:41
@@ -106,6 +106,14 @@ private function updateMimetypes($updatedMimetypes) {
return $count;
}

private function introduceExcalidrawType() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be an opportunity to add return type hint here and in updateMimetypes()

@hweihwang hweihwang requested a review from blizzz May 20, 2024 09:26
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@juliushaertl
Copy link
Member

Tests needs some adjustment it seems:

  1. Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithModifiedMimetypelistSignatureData

@juliushaertl
Copy link
Member

@hweihwang Pushed a small commit to adjust the icon color to match the others.

@hweihwang hweihwang force-pushed the feat/excalidraw-file-support branch from 9db358a to 17e3140 Compare June 13, 2024 08:51
@juliushaertl
Copy link
Member

Looks good, cypress seems unrelated, could you squash your commits and rebase to latest master afterwards? Will push my icon fix again then afterwards.

@juliushaertl
Copy link
Member

@hweihwang Had another conflict in the mean time, could you check?

@hweihwang hweihwang force-pushed the feat/excalidraw-file-support branch from 86d2094 to 1b193e7 Compare June 27, 2024 09:03
@hweihwang hweihwang force-pushed the feat/excalidraw-file-support branch 3 times, most recently from c78924d to 906b5f8 Compare June 27, 2024 09:59
@hweihwang hweihwang force-pushed the feat/excalidraw-file-support branch 2 times, most recently from 540e2df to 6da0296 Compare June 27, 2024 10:06
hweihwang and others added 2 commits July 4, 2024 11:09
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl marked this pull request as ready for review July 4, 2024 11:35
@juliushaertl juliushaertl merged commit 7e66330 into master Jul 4, 2024
170 checks passed
@juliushaertl juliushaertl deleted the feat/excalidraw-file-support branch July 4, 2024 15:27
Copy link

welcome bot commented Jul 4, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@juliushaertl
Copy link
Member

/backport to stable29

@juliushaertl
Copy link
Member

/backport to stable28

Copy link

backportbot bot commented Jul 4, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/45353/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a2f026b f5fbe435

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45353/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jul 4, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/45353/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a2f026b f5fbe435

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45353/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants