Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(S3): Adjust typing for 32bit compatibility #44462

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 25, 2024

Checklist

@susnux susnux added bug 3. to review Waiting for reviews regression labels Mar 25, 2024
@susnux susnux added this to the Nextcloud 29 milestone Mar 25, 2024
@susnux susnux requested review from Altahrim, artonge and come-nc March 25, 2024 20:02
@Altahrim Altahrim mentioned this pull request Mar 26, 2024
@susnux
Copy link
Contributor Author

susnux commented Mar 26, 2024

Psalm is related - need to add doc comment I think. ✍️ 📓

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/object-trait branch from 4714e63 to 7880086 Compare March 26, 2024 12:07
@susnux susnux enabled auto-merge March 26, 2024 12:11
@susnux susnux merged commit 4b7b9c3 into master Mar 26, 2024
167 checks passed
@susnux susnux deleted the fix/object-trait branch March 26, 2024 12:51
Copy link
Contributor

github-actions bot commented May 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants