feat(ObjectStore): Make the S3 concurrency option configurable
#44252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
3. to review
susnux
force-pushed
the
enh/s3-connectivity
branch
4 times, most recently
from
5a1041b to
67e17de
Compare
|
No idea whats up with Cypress, but that is unrelated... |
Altahrim
approved these changes
Mar 18, 2024
Merged
Merged
come-nc
requested changes
Mar 21, 2024
…members are in sync Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
enh/s3-connectivity
branch
from
67e17de to
32dee2f
Compare
come-nc
approved these changes
Mar 21, 2024
|
@susnux https://github.com/nextcloud/server/actions/runs/8413780258/job/23036516249 Sorry I missed that, you cannot type sizes as |
4 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on this: #24330 (comment)
So this makes the concurrency option configurable which might help in some cases, but still defaults to 5 like the S3 SDK is doing.
Docs: nextcloud/documentation#11661
Checklist