Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove comments tab from files #41201

Closed
wants to merge 2 commits into from

Conversation

sorbaugh
Copy link
Contributor

Summary

This is the the second part of a two part Pull Request to move code from the comments app found in server to the activity app.

Here is the other PR: nextcloud/activity#1387

Checklist

apps/comments/src/comments-app.js Show resolved Hide resolved
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Oct 31, 2023
@nickvergessen
Copy link
Member

Setting pending documentation This pull request needs an associated documentation update because it's needed in case the feature is being deprecated or removed directly.

@sorbaugh
Copy link
Contributor Author

Thanks for pointing it out! For context, the comments feature is being moved to the activity repo, so this is one of two pull requests.
nextcloud/activity#1387

lib/private/Comments/Manager.php Outdated Show resolved Hide resolved
lib/private/Comments/Manager.php Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file still needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the use of this file?

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, most of this need to be kept as:

if activity app is disabled and comments app enabled:
show comments tab as-is

@nickvergessen
Copy link
Member

That also means we can keep the public API working for apps using the comments UI, that's great news!

This was referenced Nov 6, 2023
@blizzz blizzz mentioned this pull request Nov 14, 2023
@susnux
Copy link
Contributor

susnux commented Nov 15, 2023

closing in favor of #41491
(for reuse code and not duplicate comments code to activity app)

@susnux susnux closed this Nov 15, 2023
@susnux susnux deleted the feature/sorbaugh/combine-comments-activity branch November 15, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: comments pending documentation This pull request needs an associated documentation update technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants